SAK-37749 Lessonbuilder accessibility collapsible sections cannot be opened with keyboard #12965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opened with keyboard
ern
reviewed
Oct 22, 2024
…opened with keyboard
kunaljaykam
reviewed
Nov 20, 2024
| @@ -2387,11 +2387,12 @@ <h5 class="modal-title" id="titleModalLabel" rsf:id="msg=simplepage.title">simpl | |||
| <h3 rsf:id="msg=simplepage.maincontent" class="lb-offscreen" id="maintablelabel"></h3> | |||
| <!-- WARNING: javascript for add-break-section adds section, ul, li, and sectionedit markup, so if you change here, keep it in sync --> | |||
| <div rsf:id="sectionWrapper:"> | |||
| <h3 rsf:id="sectionHeader" id="sectionHeader" class="sectionHeader"> | |||
| <a rsf:id="sectionHeader" id="sectionHeader" class="sectionHeader d-block text-decoration-none h3" href="#collapsibleContent" tabindex="0" data-bs-toggle="collapse" aria-expanded="true" aria-controls="collapsibleContent"> | |||
There was a problem hiding this comment.
d-block looks a bit better as this element spans the whole width
ottenhoff
requested changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the element focusable and added a keydown event handler.